Skip to content

Commit

Permalink
[test] runtime env pip version pinned to 24.1.2 for python 3.12 suppo…
Browse files Browse the repository at this point in the history
…rt (ray-project#46574)

The old version (20.2.3) will fail
`test_runtime_env_conda_and_pip_4.py::test_runtime_env_with_pip_config`
showing error like:

```
No module named 'pip._vendor.six.moves'
```

After upgrade, it will pass.

Signed-off-by: hongchaodeng <[email protected]>
  • Loading branch information
hongchaodeng committed Jul 11, 2024
1 parent 19dc58e commit 04cb892
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions python/ray/tests/test_runtime_env_conda_and_pip_4.py
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,15 @@ def test_run_in_virtualenv(cloned_virtualenv):
def test_runtime_env_with_pip_config(start_cluster):
@ray.remote(
runtime_env={
"pip": {"packages": ["pip-install-test==0.5"], "pip_version": "==20.2.3"}
"pip": {"packages": ["pip-install-test==0.5"], "pip_version": "==24.1.2"}
}
)
def f():
import pip

return pip.__version__

assert ray.get(f.remote()) == "20.2.3"
assert ray.get(f.remote()) == "24.1.2"


if __name__ == "__main__":
Expand Down
6 changes: 3 additions & 3 deletions python/ray/tests/test_runtime_env_conda_and_pip_5.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
def test_runtime_env_with_pip_config(start_cluster):

pip_versions = [
("==20.2.3", lambda pip_version: parse(pip_version) == parse("20.2.3")),
("==24.1.2", lambda pip_version: parse(pip_version) == parse("24.1.2")),
(
"<20.3, >19",
lambda pip_version: parse("19") < parse(pip_version) < parse("20.3"),
"<24.2, >19",
lambda pip_version: parse("19") < parse(pip_version) < parse("24.2"),
),
]

Expand Down

0 comments on commit 04cb892

Please sign in to comment.