Skip to content
This repository has been archived by the owner on Feb 26, 2023. It is now read-only.

Support Android Gradle Plugin 3.5.0-beta03 and 3.6.0-alpha01 #2231

Merged

Conversation

dodgex
Copy link
Member

@dodgex dodgex commented May 30, 2019

Google updated the generated code folder for Java Builds and with this PR we support those new folders for Manifest detection. :)

Fixes #2229.

(cherry picked from commit 1c48970ade71852c8a3e305641ef88a105d35f2d)
(cherry picked from commit c7bc0b574234c537b4f976df35d215eba8b7f9a0)
(cherry picked from commit de366e34d77424c95be0ddce1e1e1fdd4c70bbd7)
(cherry picked from commit 754a09a69f9740695dadb7900113ba1e98a9f7dc)
@psmorandi
Copy link

Hello there, could anyone review this?? AA is failing for the new android gradle plugin released (3.5.0).

@WonderCsabo
Copy link
Member

I'll try to review this on Monday.

@WonderCsabo WonderCsabo merged commit d99e1c7 into androidannotations:develop Aug 30, 2019
@WonderCsabo WonderCsabo added this to the 4.7.0 milestone Aug 30, 2019
@dodgex dodgex deleted the 2229_update_manifest_finder branch August 31, 2019 22:50
@WonderCsabo
Copy link
Member

The fix is now available in the 4.7.0-SNAPSHOT build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AGP 3.5.0 - Could not find the AndroidManifest.xml file, using generation folder
4 participants