This repository has been archived by the owner on Feb 26, 2023. It is now read-only.
Revert "Add useful methods to PluginClassHolder" #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dodgex , sorry I really forgot to PR this revert, I got really overloaded on last months. Hopefully I'll get some free time later this year to continue contributions. Thanks!! |
|
@smaugho no problem, honestly I (and i assume Csaba too) didn't had that much time too. :) I'd like to ask if you are OK if i close your other open PRs as it seems that they either introduce breaking changes or depend on one of those breaking change PRs. we would be happy to review upcoming PRs that hopefully do not break stuff. :) |
|
Yes @dodgex that's ok 👍 |
This was referenced May 30, 2019
WonderCsabo
approved these changes
Sep 1, 2019
dodgex
deleted the
revert-2215-add_useful_methods_plugin_class_holder
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts #2215 as it unfortunately introduces breaking changes for plugins.