-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PluginGroupConfiguration,PluginGroup,Plugin missed in no.op #293
Labels
bug
Something isn't working
Comments
this is happening coz let me know if you face any issue in this. |
Hi, I keep it in variantfolder but it is not comfortable)
…On Wed, 29 Nov 2023, 07:06 Prateek, ***@***.***> wrote:
this is happening coz plugin module does not have no-op version, as it
did not need it.
the fix for the above issue is to keep your PluginGroup file in variant
folder (can refer to the sample app).
let me know if you face any issue in this.
—
Reply to this email directly, view it on GitHub
<#293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCTUBZ5AMFHZ2WHMROG3DOTYG27GLAVCNFSM6AAAAAA7WO2JHKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZRGIZTAMZRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
PluginGroupConfiguration,PluginGroup,Plugin missed in no.op
To Reproduce
Steps to reproduce the behavior:
Setup no.op for prod build variant
"prodApi"(libs.plutolib.plugins.bundle.core.no.op)
"prodApi"(libs.plutolib.pluto.no.op)
Create class with plugins
class DataSourcePluginGroup : PluginGroup("datasource-group") {
override fun getConfig() = PluginGroupConfiguration(
name = "DataSource Group"
)
override fun getPlugins(): List {
return listOf(
PlutoSharePreferencesPlugin(),
PlutoDatastorePreferencesPlugin(),
PlutoRoomsDatabasePlugin()
)
}
}
Add plugin groupe in Pluto
Pluto.Installer(this)
.addPlugin(PlutoLoggerPlugin())
.addPlugin(PlutoNetworkPlugin())
.addPlugin(PlutoExceptionsPlugin())
//.addPlugin(PlutoLayoutInspectorPlugin())
.addPluginGroup(DataSourcePluginGroup())
.install()
Expected behavior
build variant with no.op should works
The text was updated successfully, but these errors were encountered: