Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/Convert object to data object in sealed interface #999

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

KDW03
Copy link
Contributor

@KDW03 KDW03 commented Oct 25, 2023

Thanks for submitting a pull request. Please include the following information.

What I have done and why
Include a summary of what your pull request contains, and why you have made these changes.

By leveraging the data object feature introduced and stabilized in Kotlin version 1.9.0, this refactor will provide a more descriptive toString() representation, ensuring a uniform approach to defining states across sealed interfaces and enhancing the debuggability with the improved toString() method.

Fixes #998

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?

Copy link
Collaborator

@dturner dturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for doing this.

@dturner dturner merged commit 15f8861 into android:main Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Apply data objects in uiState sealed interfaces
2 participants