NavigationSuiteScaffold #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoczkowski
force-pushed
the
feature/navigation-suite-scaffold
branch
from
b1b92ac
to
227bfd3
Compare
alexvanyo
requested changes
Sep 13, 2023
app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaAppState.kt
Outdated
Show resolved
Hide resolved
mmoczkowski
force-pushed
the
feature/navigation-suite-scaffold
branch
from
ecb4d7b
to
e43f383
Compare
alexvanyo
reviewed
Sep 26, 2023
app/src/testDemo/screenshots/expandedWidth_mediumHeight_showsNavigationRail.png
Outdated
Show resolved
Hide resolved
app/src/main/java/com/google/samples/apps/nowinandroid/ui/NiaAppState.kt
Outdated
Show resolved
Hide resolved
alexvanyo
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Current limitations make sense with the current APIs, looks great @mmoczkowski !
IanGClifton
reviewed
Nov 9, 2023
app/src/main/kotlin/com/google/samples/apps/nowinandroid/MainActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppState.kt
Outdated
Show resolved
Hide resolved
app/src/testDemo/screenshots/expandedWidth_mediumHeight_showsNavigationRail.png
Outdated
Show resolved
Hide resolved
mmoczkowski
force-pushed
the
feature/navigation-suite-scaffold
branch
4 times, most recently
from
fc88abf
to
878bf64
Compare
…eScaffold Change-Id: I54b402e28b6e1bd400c9f44644bd4dd35c98e723
mmoczkowski
force-pushed
the
feature/navigation-suite-scaffold
branch
from
544e4db
to
816a7b6
Compare
3 tasks
3 tasks
mmoczkowski
added a commit
that referenced
this pull request
Nov 21, 2023
Revert "Merge pull request #942 from android/feature/navigation-suite…
|
Hello @mmoczkowski Would you be willing to reopen this pull request? |
|
NavigationSuiteScaffold will get added back in later but the APIs need to stabilize and depend on a stable version of Compose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BottomBarandNavRailnavigation components withNavigationSuiteScaffoldAPINavigationSuiteScaffoldAPI to displayPermanentDraweron screen widths larger than1240.dpPermanentDraweris properly displayed:largeScreenWidth_compactHeight_showsPermanentDrawer,largeScreenWidth_mediumHeight_showsPermanentDrawer,largeScreenWidth_expandedHeight_showsPermanentDrawerniaAppState_showBottomBar_compact,niaAppState_showNavRail_mediumandniaAppState_showNavRail_largeintegration tests. They are redundant and already covered by screenshot tests.2023.09.00- required forNavigationSuiteScaffoldto work in integration tests.notificationDotmodifier and replace is withBadgedBox