Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve accessibility to ForYou topics #1309

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Improve accessibility to ForYou topics #1309

wants to merge 12 commits into from

Conversation

Jaehwa-Noh
Copy link
Contributor

@Jaehwa-Noh Jaehwa-Noh commented Mar 20, 2024 •
edited
Loading

What I have done and why
• Merge Descendant semantics
• Clear Icon button semantics
• Change Icon description
• Change test logic state to display

By following this documentation improve accessibility.

Android20240413_130912

@Jaehwa-Noh
Clear semantics.
45c7504 
Change-Id: I69a48798f6be8433e877c38166bd73cd776d71ac
@Jaehwa-Noh
Merge the descendants semantics.
a1e7dc4 
Change-Id: Ifbe91bb694b393e6780f93732a7d38f5ee355680
@Jaehwa-Noh Jaehwa-Noh marked this pull request as draft March 20, 2024 11:57
@Jaehwa-Noh
Add string for icon description.
5488544 
Change-Id: Ibf35c651aeacfbe317794ed898f0fb0e8bc1ec15
@Jaehwa-Noh
Change icon description.
ecf6e9e 
Change-Id: I9359bf8c9272b247669ae58fd79e5f79466ec0a9
@Jaehwa-Noh
Change state of icon check logic.
5401baa 
Change-Id: I3e5e89fc1c469c3f3c4744d18f697f68d070996b
@Jaehwa-Noh Jaehwa-Noh changed the title Improve accessibility Improve accessibility to ForYou topics Mar 21, 2024
@Jaehwa-Noh Jaehwa-Noh marked this pull request as ready for review March 21, 2024 06:02
@Jaehwa-Noh Jaehwa-Noh mentioned this pull request Mar 22, 2024
Open
@Jaehwa-Noh Jaehwa-Noh marked this pull request as draft March 27, 2024 00:18
@Jaehwa-Noh
Merge only text.
d7ac889 
Change-Id: I36eefc6dd9f56f7a1f63003f0f95f6755ae16def
@Jaehwa-Noh
Add stateDescription.
11bde26 
Change-Id: Id4d32e49374dbdb6e666048937e37060cbd4b454
@Jaehwa-Noh
Add toggleableState.
b178aa1 
Change-Id: I9f836e2463bf800786d11f9e0997a7d570ff90b0
@Jaehwa-Noh
Set clearAndSetSemantics at Row.
d338583 
Change-Id: Ic25b9ca11bbcc40c8ff24172669b07ea9b7642a9
@Jaehwa-Noh
Set stateDescription "Following" and "Not Following".
ff92727 
Change-Id: Ib82ac94b05a5d373ac10787aac5241fb4f03c7b2
@Jaehwa-Noh Jaehwa-Noh marked this pull request as ready for review April 13, 2024 04:14
@Jaehwa-Noh
Find topic by onNodeWithContentDescription.
1f0f5b8 
Change-Id: I2423e3846c02169f6bf1fc30d9b4034b5f79efb3
@Jaehwa-Noh
Find topic by onNodeWithContentDescription.
7b5b7c6 
Change-Id: Iefc97fd9e52227f51f7d40f8c10cb4878cde90c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Jaehwa-Noh