Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Significant amount of overdraw throughout the app #514

Open
3 tasks done
IanGClifton opened this issue Dec 29, 2022 · 3 comments
Open
3 tasks done

[Bug]: Significant amount of overdraw throughout the app #514

IanGClifton opened this issue Dec 29, 2022 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed p1 High priority

Comments

@IanGClifton
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

If you enable "Debug GPU overdraw" in the Developer options, you'll see most of the app is pink (3 levels of overdraw) or red (4+ levels of overdraw). A big chunk of this is coming from the backgrounds. For example, NiaBackground creates a Surface, then NiaGradientBackground creates another Surface and also potentially draws on top, then Scaffold creates another Surface (though it looks transparent), and then the content is drawn on top of that.

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@IanGClifton IanGClifton added the bug Something isn't working label Dec 29, 2022
@kdani41
Copy link

kdani41 commented Dec 29, 2022

There is already a StackOverflow issue regarding this. Looks like the main culprit is card surface.

@IanGClifton
Copy link
Author

Card should only create a single level of overdraw from its Surface, which is fine. On its own, that would be blue, so the pinks and reds indicate multiple additional levels.

@dturner dturner added help wanted Extra attention is needed p1 High priority labels Jan 9, 2023
@alexvanyo
Copy link
Contributor

This might relate to #349 with regards to the background setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed p1 High priority
Projects
None yet
Development

No branches or pull requests

4 participants