-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR]: NiaApp background composable could be improved #349
Comments
Was this referencing how changing the background gradient by screen makes the navigation more janky? Example, going from ForYou <-> Saved, it's a bit jarring, no soft transition because ForYou has a custom Wonder if there's a better way to go about this, otherwise, we should just keep the background local to the screen. |
The original comment was for the non-standard setup for the background that looks like The setup here is a bit tricky, since we want the background to be displayed behind some shared elements (like the nav bar), but it is different depending on the destination like you mentioned. We should be able to replace the current setup with one that uses |
Is there an existing issue for this?
Describe the problem
Context: https://github.com/android/nowinandroid/pull/330/files/ee4eb25ba07e7a017c52f54fa49547a0e733ff8b#r1001237941
From @manuelvicnt:
What's this complexity? Could this be a slot API instead? And the content inside it could be using moveableContent so that state isn't lost
Describe the solution
Let's discuss this in our weekly.
Additional context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: