Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated API are replaced #656

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Conversation

zakharovsergey1000
Copy link
Contributor

Deprecated InstrumentationRegistry.getContext() and InstrumentationRegistry.getTargetContext() are replaced with ApplicationProvider.getApplicationContext()

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@zakharovsergey1000
Copy link
Contributor Author

I signed it!

@dlam
Copy link
Contributor

dlam commented Jun 19, 2019

@zakharovsergey1000 I believe you may need to correct the commit author in order for googlebot to recognize CLA status.

Check the "Individual Signers" section in googlebot's message above.

Make sure your git commit author name and email are set correctly:

git config --global user.name "Foo Bar"
git config --global user.email "[email protected]"

And then you can git commit --amend --author"Foo Bar<[email protected]>" to edit the author of your last commit.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

…gistry.getTargetContext() are replaced with ApplicationProvider.getApplicationContext()
@dlam dlam self-assigned this Jun 20, 2019
@dlam dlam self-requested a review June 20, 2019 20:33
@dlam dlam merged commit 08a85fa into android:master Jun 21, 2019
@dlam
Copy link
Contributor

dlam commented Jun 21, 2019

Thanks for helping with sample cleanup @zakharovsergey1000 🙂

@zakharovsergey1000
Copy link
Contributor Author

I'm glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants