Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #6

Merged
merged 4 commits into from
Jul 30, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update api.auth
  • Loading branch information
andrenerd committed Jul 30, 2020
commit 3e0986e79d1f9a68521d615351669f821289971c
83 changes: 43 additions & 40 deletions multauth/api/auth/serializers.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.contrib.auth import authenticate
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.contrib.auth import get_user_model

from rest_framework import exceptions, serializers
Expand All @@ -25,43 +25,6 @@ class TokenSerializer(serializers.Serializer):
# RESERVED # expired_datetime = serializers.DateTimeField(read_only=True) # could be timestamp


class SigninSerializer(serializers.ModelSerializer):
hardcode = serializers.CharField(required=False)
passcode = serializers.CharField(required=False)

class Meta:
model = UserModel
fields = tuple(IDENTIFIERS + SECRETS)

# experimental
extra_kwargs = dict([]
+ [(x, {'required': False}) for x in IDENTIFIERS] # 'validators': None
+ [(x, {'required': False}) for x in SECRETS]
)

def validate(self, data):
model = self.Meta.model

# check identifiers
data_identifiers = [x for x in data if x in IDENTIFIERS and data.get(x, None)]
if not data_identifiers:
msg = _('Invalid user credentials. No valid identifier found')
raise exceptions.ValidationError(msg)

user = authenticate(**data)

if user:
if not user.is_active:
msg = _('User account is disabled.')
raise exceptions.ValidationError(msg)
else:
msg = _('Unable to log in with provided credentials.')
raise exceptions.ValidationError(msg)

data['user'] = user
return super().validate(data)


class SignupSerializer(serializers.ModelSerializer):
"""
For write (POST...) requests only
Expand All @@ -86,8 +49,6 @@ class Meta:
def validate(self, data):
model = self.Meta.model

# check for one valid idntifier

# check identifiers
data_identifiers = [x for x in data if x in IDENTIFIERS and data.get(x, None)]
if not data_identifiers:
Expand Down Expand Up @@ -115,3 +76,45 @@ class Meta:
+ [x for x in confirmation_fields if hasattr(UserModel, x)] # only that way :/
+ ['is_active']
)


signin_serializer_fields = dict([
[x, serializers.ModelField(model_field=UserModel()._meta.get_field(x), required=False)]
for x in (IDENTIFIERS + SECRETS) if hasattr(UserModel, x)
])


def signin_serializer_validate(self, data):
# model = self.Meta.model

# check identifiers
data_identifiers = [x for x in data if x in IDENTIFIERS and data.get(x, None)]
if not data_identifiers:
msg = _('Invalid user credentials. No valid identifier found')
raise exceptions.ValidationError(msg)

user = authenticate(**data)

if user:
if not user.is_active:
msg = _('User account is disabled.')
raise exceptions.ValidationError(msg)
else:
msg = _('Unable to log in with provided credentials.')
raise exceptions.ValidationError(msg)

data['user'] = user
return super(SigninSerializer, self).validate(data)


SigninSerializer = type(
'SigninSerializer',
(serializers.Serializer,),
{
# reserved # '__module__': 'multauth.api.auth',
'validate': signin_serializer_validate,
'hardcode': serializers.CharField(required=False),
'passcode': serializers.CharField(required=False),
**signin_serializer_fields,
}
)
2 changes: 1 addition & 1 deletion multauth/api/auth/views.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from django.db import transaction
from django.contrib.auth import get_user_model
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, parsers, views, status
from rest_framework.permissions import AllowAny, IsAuthenticated
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/authentication.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import authentication
from rest_framework import exceptions
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/email/auth/serializers.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.contrib.auth import authenticate
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.contrib.auth import get_user_model

from rest_framework import exceptions, serializers
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/email/auth/views.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.db import transaction
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, parsers, views, status
from rest_framework.permissions import AllowAny, IsAuthenticated
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/email/me/serializers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, serializers

Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/email/me/views.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.db import transaction
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, parsers, views, status
from rest_framework.permissions import IsAuthenticated
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/phone/auth/serializers.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.contrib.auth import authenticate
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, serializers

Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/phone/auth/views.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.db import transaction
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, parsers, views, status
from rest_framework.permissions import AllowAny, IsAuthenticated
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/phone/me/serializers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, serializers

Expand Down
2 changes: 1 addition & 1 deletion multauth/api/devices/phone/me/views.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.db import transaction
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, parsers, views, status
from rest_framework.permissions import IsAuthenticated
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/me/serializers.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.contrib.auth import get_user_model

from rest_framework import exceptions, serializers
Expand Down
2 changes: 1 addition & 1 deletion multauth/api/me/views.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from django.db import transaction
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _

from rest_framework import exceptions, parsers, views, status
from rest_framework.permissions import IsAuthenticated
Expand Down
4 changes: 2 additions & 2 deletions multauth/backends.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

FLOWS = tuple(getattr(settings, 'MULTAUTH_FLOWS', (
('username', 'password'),
#('email', 'password'),
('email', 'password'),
)));

FLOWS = FLOWS if type(FLOWS[0]) is tuple else tuple([FLOWS])
Expand Down Expand Up @@ -73,7 +73,7 @@ def authenticate(self, request, **kwargs):
except UserModel.DoesNotExist:
# Run the default password hasher once to reduce the timing
# difference between an existing and a nonexistent user (#20760).
UserModel().set_password(password)
UserModel().set_password(None)
else:
if self.user_can_authenticate(user):
flow_secrets = [x for x in flow if x in UserModel.SECRETS]
Expand Down
2 changes: 1 addition & 1 deletion multauth/devices/_chip.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from django.db import models
from django.template.loader import get_template
from django.template import TemplateDoesNotExist, TemplateSyntaxError
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.conf import settings

from .abstract import AbstractDevice, AbstractUserMixin
Expand Down
2 changes: 1 addition & 1 deletion multauth/devices/email.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from django.contrib.sites.shortcuts import get_current_site
from django.template.loader import get_template
from django.template import TemplateDoesNotExist, TemplateSyntaxError
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.conf import settings

from django_otp.util import random_hex
Expand Down
2 changes: 1 addition & 1 deletion multauth/devices/phone.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from django.contrib.auth.hashers import check_password, is_password_usable, make_password
from django.template.loader import get_template
from django.template import TemplateDoesNotExist, TemplateSyntaxError
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.conf import settings

from phonenumber_field.modelfields import PhoneNumberField
Expand Down
2 changes: 1 addition & 1 deletion multauth/devices/username.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from django.db import models
from django.contrib.auth.hashers import check_password, is_password_usable, make_password
from django.contrib.auth.validators import UnicodeUsernameValidator
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.conf import settings

from django_otp.util import random_hex
Expand Down
2 changes: 1 addition & 1 deletion multauth/mixins.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from django.db import models
from django.db.models.signals import post_save
from django.utils.translation import ugettext_lazy as _
from django.utils.translation import gettext_lazy as _
from django.conf import settings
from django_otp import devices_for_user

Expand Down