Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type parameter is not properly added to searchContent() method #343

Closed
bocops opened this issue Nov 14, 2023 · 1 comment · Fixed by #345
Closed

Type parameter is not properly added to searchContent() method #343

bocops opened this issue Nov 14, 2023 · 1 comment · Fixed by #345
Assignees
@bocops
Labels
bug Something isn't working

Comments

@bocops
Copy link
Collaborator

bocops commented Nov 14, 2023

In SearchMethods.buildParameters(), type.name is added as parameter value. This needs to be lowercase, or we need to return to explicitly giving values in the respective enums.

Changing this fixes #342 for the individual-type case, but not for the generic case.

https://github.com/andregasser/bigbone/blob/12d6648c6b2da33b433ad24c5f5701657cddc9c4/bigbone/src/main/kotlin/social/bigbone/api/method/SearchMethods.kt#L90C37-L90C37
@PattaFeuFeu
Copy link
Collaborator

That’s what I went with apiName for: https://github.com/andregasser/bigbone/pull/333/files#diff-280566822ab91ce8d3fb06b56002ba761d602539a5587f87b1ce86775fe6ee1fR146

@bocops bocops added the bug Something isn't working label Nov 14, 2023
@bocops bocops self-assigned this Nov 15, 2023
bocops added a commit to bocops/bigbone that referenced this issue Nov 15, 2023
@bocops
Allow searches for individual types
388cdfc 
- change searchContent() parameter "type" to use values understood by Mastodon server
- add test failing for previous behaviour

Fixes andregasser#343.
@bocops bocops mentioned this issue Nov 15, 2023
Merged
6 tasks
PattaFeuFeu pushed a commit that referenced this issue Nov 15, 2023
@bocops
Allow searches for individual types (#345)
4a5b82b 
- change searchContent() parameter "type" to use values understood by Mastodon server
- add test failing for previous behaviour

Fixes #343.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bocops bocops

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow searches for individual types bocops/bigbone
2 participants
@PattaFeuFeu @bocops