-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDU - Controlar datos del profesional asociado al usuario #3018
base: master
Are you sure you want to change the base?
Conversation
src/app/app.component.ts
Outdated
if (profesional) { | ||
this.profesional = profesional; | ||
this.auth.setProfesionalHabilitado(profesional.habilitado); | ||
this.profesionalService.get({ documento: this.auth.usuario.documento }).subscribe(profesional => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Campe hay un problema con esta funcion; como está hecha para una búsqueda tipo filtro, si el dni que se está buscando es subcadena de otro dni entonces también lo va a traer. Habría que ..
- modificar la búsqueda para que ofrezca la opcion de matching exacto
- controlar en el response que efectivamente se trate de la misma persona
(En ambos casos aclararía la situación en el codigo con algun comentario)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corregido, se agregó un parametro mas llamado busquedaExacta que se utiliza desde la API para hacer un matcheo exacto con el profesional.
const profHabilitado = profesional.find(prof => prof.habilitado); | ||
this.profesional = profHabilitado || profesional[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const profHabilitado = profesional.find(prof => prof.habilitado); | |
this.profesional = profHabilitado || profesional[0]; | |
this.profesional = profesional.filter(prof => prof.habilitado); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Este comentario se ignora ya que se aplica la primera sugerencia de cambio.
|
||
this.profesional = profesional[0]; | ||
this.profesionalHabilitado = profesional.find(prof => prof.habilitado === true); | ||
this.profesional = this.profesionalHabilitado || profesional[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem a la sugerencia anterior
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idem al comentario anterior!
52825c9
to
d7a5371
Compare
d7a5371
to
254eddc
Compare
254eddc
to
734d42d
Compare
Requerimiento
https://proyectos.andes.gob.ar/browse/GDU-64
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion