-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MISC - Modificar ficha epidemiológica #3017
Conversation
if (sec.name !== SECCION_CONTACTOS_ESTRECHOS && sec.name !== SECCION_OPERACIONES) { | ||
const buscado = this.secciones.findIndex(seccion => seccion.name === sec.name); | ||
if (buscado !== -1) { | ||
if (sec.name === SECCION_USUARIO && this.editFicha) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recomiendo usar seccion.id en las comparaciones ya que en varias oportunidades han solicitado cambiar el "label" de la sección
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corregido!
@@ -35,7 +35,7 @@ export class FormPresetResourcesService extends ResourceBaseHttp<Event> { | |||
break; | |||
case 'mpi': | |||
seccion.fields['nacionalidad'] = paciente.direccion[1]?.ubicacion.pais ? paciente.direccion[1].ubicacion.pais : ''; | |||
seccion.fields['direccioncaso'] = paciente.direccion[0].valor ? paciente.direccion[0].valor : ''; | |||
seccion.fields['direccioncaso'] = paciente.direccion[0]?.valor ? paciente.direccion[0].valor : ''; | |||
seccion.fields['lugarresidencia'] = paciente.direccion[0].ubicacion.provincia ? paciente.direccion[0].ubicacion.provincia : ''; | |||
seccion.fields['localidadresidencia'] = paciente.direccion[0].ubicacion.localidad ? paciente.direccion[0].ubicacion.localidad : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
en las dos ultimas asignaciones no se esta controlando que exista "paciente.direccion[0]" y esto puede generar un error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corregido.
e99e5d9
to
458df72
Compare
<plex-table-columns> | ||
</plex-table-columns> | ||
<tr *ngFor="let contacto of contactosEstrechos"> | ||
<td *plTableCol="'apellidoNombre'">{{contacto.apellidoNombre}}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usar el pipe de nombre si se puede
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
estos no son datos de pacientes tabulados
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Campe, aca no se podría utlizar el pipe, dado que estos tipos de contactos no cuentan con la info necesaria para un pipe "nombre", es decir que el dato ingresado no cuenta con la esturctucra de nombre, apellido o alias.
</plex-table-columns> | ||
<tr *ngFor="let contacto of contactosEstrechos"> | ||
<td *plTableCol="'apellidoNombre'">{{contacto.apellidoNombre}}</td> | ||
<td *plTableCol="'dni'">{{contacto.dni}}</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aca se puede utilizar el pipe de documento
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
estos no son datos de pacientes tabulados
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sugerencia aplicada compa, gracias.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viendo en conjunto con @MarianoCampetella podemos notar lo siguiente:
Eso es todo! Gracias. Compas! Se agregan la sugerencias en la corrección. |
Excelente las correcciones Fabi. Solamente te faltó agregar un toast cuando se elimina un contacto estrecho (al momento de seleccionar el boton con el icono del tacho). Corregido compa! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fabi, un par de detallitos que encontré agregando contacto estrecho:
El resto de 10! Lauchin! quedaron subidos los cambios. |
Requerimiento
https://proyectos.andes.gob.ar/browse/MISC-338
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
"_id" : ObjectId("600aca822f344454af894c21"),
"activo" : true,
"type" : "section",
"name" : "Usuario",
"id" : "usuario",
"preset" : "usuario",
"__v" : 0.0
}
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion