CIT - Ventanilla: No dar turno en agenda dinamica #2946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanIRamirez
force-pushed
the
CIT-249
branch
2 times, most recently
from
ce39b5a
to
c00f8c6
Compare
MarianoCampetella
force-pushed
the
CIT-249
branch
from
c00f8c6
to
8b3f88c
Compare
MarianoCampetella
requested changes
Dec 22, 2023
| } | ||
| } | ||
|
|
||
| agendaDinamicaFutura(dia) { | ||
| return (dia.dinamicasIndefinidas > 0 && moment(dia.fecha).format('DD/MM/YYYY') > moment().format('DD/MM/YYYY')); |
There was a problem hiding this comment.
ya que utilizamos moment, las comparaciones de las fechas no son a través de los símbolos <, > o = sino con isBefore, isAfter, etc. En la siguiente documentación hay varios ejemplos para trabajar sobre las comparaciones: https://momentjs.com/docs/
| @@ -1320,6 +1320,18 @@ export class DarTurnosComponent implements OnInit { | |||
| this.showSobreturno = !this.showSobreturno; | |||
| } | |||
|
|
|||
| agendaDeHoy() { | |||
| return (moment(this.agenda.horaInicio).format('DD/MM/YYYY') === moment().format('DD/MM/YYYY')); | |||
There was a problem hiding this comment.
Similar al comentario anterior!
|
Espero a la realización de los cambios propuestos por campe para finalizar review. Dejo corriendo tests |
JuanIRamirez
added
changes done
and removed
changes requested
Fabio-Ramirez
approved these changes
May 30, 2024
There was a problem hiding this comment.
Juan este pr cumple con las especificaciones iniciales. Lo que menciona @AgosLizzi sobre una nueva sugerencia: https://proyectos.andes.gob.ar/browse/UIUX-374, será parte de otra tarea. Tener presente la actualización y testeo posterior.
MarianoCampetella
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requerimiento
https://proyectos.andes.gob.ar/browse/CIT-249
Funcionalidad desarrollada
UserStory llegó a completarse
Requiere actualizaciones en la base de datos
Requiere actualizaciones en la API
Requiere actualizaciones en andes-test-integracion