Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUP - Control de permisos de prestacion por conceptId #2610

Merged
merged 5 commits into from
Oct 25, 2022
Merged

RUP - Control de permisos de prestacion por conceptId #2610

merged 5 commits into from
Oct 25, 2022

Conversation

negro89
Copy link
Contributor

@negro89 negro89 commented Mar 22, 2022 •
edited
Loading

Requerimiento

https://proyectos.andes.gob.ar/browse/RUP-306

Funcionalidad desarrollada

  1. Una vez que el servicio de conceptos turneables obtiene las que el usuario tiene permitidas, se realiza una busqueda por conceptId (Segun estos conceptos) antes de guardar en cache. De esta manera los permisos continuan guardandose por id pero levantandose con conceptId.
  2. Borra codigo comentado

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@negro89 negro89 requested review from a team as code owners March 22, 2022 16:42
@negro89 negro89 requested review from leon-bravo, AgosLizzi, martinebucarey and palita1991 and removed request for leon-bravo and AgosLizzi March 22, 2022 16:42
@martinebucarey
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 6097
CYPRESS RUN: 5004
TEST START: 2022-03-23T15:54:07.430Z
TOTAL: 406
SUCCESS: 337
FAIL: 68
SKIPPED: 1

@martinebucarey
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 6099
CYPRESS RUN: 5006
TEST START: 2022-03-23T16:40:40.681Z
TOTAL: 398
SUCCESS: 329
FAIL: 68
SKIPPED: 1

@martinebucarey
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 6110
CYPRESS RUN: 5015
TEST START: 2022-03-25T16:48:14.864Z
TOTAL: 406
SUCCESS: 338
FAIL: 67
SKIPPED: 1

@martinebucarey
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 6113
CYPRESS RUN: 5018
TEST START: 2022-03-25T19:13:58.471Z
TOTAL: 406
SUCCESS: 338
FAIL: 67
SKIPPED: 1

@negro89 negro89 force-pushed the RUP-306 branch 2 times, most recently from 6ebd2ac to c856872 Compare March 30, 2022 13:18
@martinebucarey
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 6148
CYPRESS RUN: 5047
TEST START: 2022-03-30T13:42:55.198Z
TOTAL: 338
SUCCESS: 309
FAIL: 28
SKIPPED: 1

@martinebucarey
Copy link
Contributor

USUARIO: lmlagos
BUILD NUMBER: 6187
CYPRESS RUN: 5083
TEST START: 2022-04-06T19:21:28.673Z
TOTAL: 406
SUCCESS: 338
FAIL: 67
SKIPPED: 1

martinebucarey
martinebucarey approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@martinebucarey martinebucarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo del script ( que nombre el PR ) no iría mas.

@silviroa silviroa self-assigned this Aug 30, 2022
@silviroa
Copy link
Contributor

USUARIO: silviroa
BUILD NUMBER: 7602
CYPRESS RUN: 6447
TEST START: 2022-09-12T14:34:43.761Z
TOTAL: 406
SUCCESS: 405
FAIL: 0
SKIPPED: 1

@silviroa silviroa added test ok Los test estan ok and removed test ok Los test estan ok labels Sep 12, 2022
@silviroa silviroa mentioned this pull request Sep 27, 2022
Merged
9 tasks
@silviroa
Copy link
Contributor

silviroa commented Oct 3, 2022

@negro89 ya no corresponden los cambios en los test no?? porque no se modifican los permisos en la base

@negro89
Copy link
Contributor Author

negro89 commented Oct 6, 2022

@silviroa tal cual, ahi lo edité. Tampoco iba lo del script.
(Rama actualizada al 06/10)

@silviroa
Copy link
Contributor

USUARIO: silviroa
BUILD NUMBER: 7802
CYPRESS RUN: 6940
TEST START: 2022-10-20T13:22:44.794Z
TOTAL: 406
SUCCESS: 405
FAIL: 0
SKIPPED: 1

@silviroa silviroa added test ok Los test estan ok and removed test ok Los test estan ok labels Oct 20, 2022
@silviroa
Copy link
Contributor

USUARIO: silviroa
BUILD NUMBER: 7822
CYPRESS RUN: 6957
TEST START: 2022-10-21T15:09:09.136Z
TOTAL: 406
SUCCESS: 404
FAIL: 1
SKIPPED: 1

@silviroa silviroa added test fail and removed test ok Los test estan ok labels Oct 21, 2022
@silviroa silviroa merged commit 6572967 into master Oct 25, 2022
@silviroa silviroa deleted the RUP-306 branch October 25, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plammel plammel plammel approved these changes

@martinebucarey martinebucarey martinebucarey approved these changes

@palita1991 palita1991 Awaiting requested review from palita1991

Assignees

@silviroa silviroa

Labels
publicar test fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@negro89 @martinebucarey @silviroa @plammel