This repository has been archived by the owner on Jun 13, 2019. It is now read-only.
#152109473 validate new product #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
femisenjobi
reviewed
Oct 31, 2017
| ] | ||
| } | ||
| ] | ||
| }, { fields: { _id: 1 } }); |
There was a problem hiding this comment.
I think you can do a .distinct('_id') instead of a separate const blankProductsId = blankProducts.map(products => products._id); Can you give that a shot ans see how it goes?
Docs here: https://docs.mongodb.com/manual/reference/method/db.collection.distinct/
femisenjobi
reviewed
Oct 31, 2017
| @@ -15,6 +15,7 @@ Template.productGrid.onCreated(function () { | |||
| }); | |||
|
|
|||
| Template.productGrid.onRendered(function () { | |||
| Meteor.call("products/removeBlankProducts"); | |||
There was a problem hiding this comment.
Looks like you're deleting the products when rendering the page, uh?
There was a problem hiding this comment.
yes. the way reaction commerce is structured. it creates the product Id immediately you click the add product button. when you enter the changes in the field it updates the products.
So, I delete the blank products from the product grid.
aimeedyki
force-pushed
the
bug/152109473/no-blank-products-in-cart
branch
from
909de04
to
0be7170
Compare
- validate product title, vendor and description fields - remove blank products from product grid [finishes #152109473] make subtitle field required make variant price compulsory
aimeedyki
force-pushed
the
bug/152109473/no-blank-products-in-cart
branch
from
0be7170
to
a10ba22
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Does not allow blank products to be saved or added to cart
Description of Task to be completed?
Ensure product title, vendor, and description fields are validated and the product grid does not display blank products.
How should this be manually tested?
As a logged in admin go to the add product page and try to add a blank product
Any background context you want to provide?
blank products were saved and displayed on the product grid and added to cart.
What are the relevant pivotal tracker stories?`
https://www.pivotaltracker.com/story/show/152109473
Screenshots (if appropriate)