This repository has been archived by the owner on Jun 13, 2019. It is now read-only.
#151980458 Actionable Analytics #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0922023
to
ae62b67
Compare
ae62b67
to
f7ecdaf
Compare
femisenjobi
suggested changes
Nov 7, 2017
There was a problem hiding this comment.
- I think we can use a better design where the date filter is not
orphanedon the page. DM'ed you some ideas - Thanks for putting the table in a container. It's good to make use of some whitespace in your design.
- getAnalytics seemed too bulky for a single function
- added a comment for the redundant calculation, just put the final answer
| */ | ||
| function daysDifference(date1, date2) { | ||
| // a Day represented in milliseconds | ||
| const oneDay = 1000 * 60 * 60 * 24; |
There was a problem hiding this comment.
No need to do this calculation here, especially since you already commented. Just put the final value
- Create a new plugin acccessible from the admin dashboard that routes to an analytics page - Add meteor packages Highcharts, mrt:moment and Pikaday - Add data visualization via charts [Finishes #151980458]
f7ecdaf
to
ba1b879
Compare
femisenjobi
approved these changes
Nov 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add an analytics page containing marketplace data and accessible only to admin.
Description of Task to be completed?
How should this be manually tested?
Log in as Admin and navigate to the statistics page from the admin dashboard. You should see tabular and graphical statistics of sales, orders, and products.
Any background context you want to provide?
A more visual format for data allows the admin to have a more quick and detailed guide to analytics regarding the shop and products. This method of data presentation will add more value by driving decisions made by the admin on future business related decisions.
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/151980458
Screenshots (if appropriate)