Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our go.mod should always be tidy --this PR adds a specific linting step to verify this on each PR.
This is important during the release step, where we run
go mod download
, which may change the go.sum (putting the workspace into an unreleasable state). The current workaround is to rungo mod tidy
to re-tidy thego.sum
after thego mod download
. This is OK, however, the assumption is that the go.mod and go.sum were in a tidy state before the download. If this isn't the case then the git state will still be dirty and the workspace will be in an unreleasable state.