Handle har no entries #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This change is only at the API level for now (no CLI flag) Set `esModuleInterop` to `true` * This fixes some typescript build errors caused by `GenerateSchema` import
Merge from upstream
swarkentin
commented
Jan 13, 2022
| @@ -49,8 +49,10 @@ export class AvantationAPI implements Avantation.InputConfig { | |||
| this.run(); | |||
| } | |||
|
|
|||
| private async run() { | |||
| this.har.log.entries.forEach(this.buildEntry.bind(this)); | |||
| private run() { | |||
There was a problem hiding this comment.
Having run as an async method in the constructor was making this difficult to test - does it need to be async?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.