Add POST functions #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
anaskhan96
approved these changes
Sep 22, 2020
|
Hi @deepsheth, thank you for the PR! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This implements POST requests, as suggested in feature request #32.
Technical Details
I introduce two new functions:
PostPostForm, a convenience function for form submission. Useful when that payload is not JSON formatted and is in the form of a query string.For
Post, the payload is aninterfacewhich can be of the following types:map[string]string,netURL.Values(for PostForm requests),[]byte, andstring.I also create a new abstraction, the function
setHeadersAndCookieswhich both GET and POST functions and use to build aRequest.Testing
Each function is tested and can be verified by running
go test.