Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defined errors to the package #44

Merged
merged 4 commits into from
Nov 17, 2019

Commits on Nov 11, 2019

  1. Add defined errors to the package

    This will allow implementors to use these errors to detect
    if an error has occurred, rather than using string comparison.
    
    This also adds an ErrorDetails field to the Root object, which
    is mostly for debugging.
    
    Add some comments and update changelog
    ghostlandr committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    a8fe12c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2019

  1. Add error implementor, to add more data but avoid backwards incompat

    Exposes a soup.Error that can be inspected to see what kind of error
    you are dealing with, then be able to further inspect the Error()
    method to see if there is any more information for you.
    
    Avoids breaking backwards compatibility by not changing the type of
    Error in the Root object, so inspecting the returned err should
    still work in other projects.
    ghostlandr committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    eac256b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    303b9dd View commit details
    Browse the repository at this point in the history
  3. Remove some test code

    ghostlandr committed Nov 17, 2019
    Configuration menu
    Copy the full SHA
    5dd62b9 View commit details
    Browse the repository at this point in the history