[FLINK-4866] [streaming] Make Trigger.clear() Abstract to Enforce Imp…

…lementation
amuraru · Oct 24, 2016 · 2c20b39 · 2c20b39
1 parent b0753f1
commit 2c20b39
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/...reaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/Trigger.java b/...reaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/Trigger.java
@@ -113,10 +113,8 @@ public TriggerResult onMerge(W window, OnMergeContext ctx) throws Exception {
  * when a window is purged. Timers set using {@link TriggerContext#registerEventTimeTimer(long)}
  * and {@link TriggerContext#registerProcessingTimeTimer(long)} should be deleted here as
  * well as state acquired using {@link TriggerContext#getPartitionedState(StateDescriptor)}.
- * 
- * <p>By default, this method does nothing.
  */
- public void clear(W window, TriggerContext ctx) throws Exception {}
+ public abstract void clear(W window, TriggerContext ctx) throws Exception;
 
  // ------------------------------------------------------------------------
 

diff --git a/...java/org/apache/flink/streaming/runtime/operators/windowing/AllWindowTranslationTest.java b/...java/org/apache/flink/streaming/runtime/operators/windowing/AllWindowTranslationTest.java
@@ -308,6 +308,9 @@ public TriggerResult onEventTime(long time,
  public boolean canMerge() {
  return false;
  }
+
+ @Override
+ public void clear(TimeWindow window, TriggerContext ctx) throws Exception {}
  });
  } catch (UnsupportedOperationException e) {
  // expected

diff --git a/...st/java/org/apache/flink/streaming/runtime/operators/windowing/WindowTranslationTest.java b/...st/java/org/apache/flink/streaming/runtime/operators/windowing/WindowTranslationTest.java
@@ -318,6 +318,9 @@ public TriggerResult onEventTime(long time,
  public boolean canMerge() {
  return false;
  }
+
+ @Override
+ public void clear(TimeWindow window, TriggerContext ctx) throws Exception {}
  });
  } catch (UnsupportedOperationException e) {
  // expected