Merge branch 'master' into write-to-finalized

.github/workflows/nightly.yml

@@ -121,8 +121,6 @@ jobs:
  docker ps --all --quiet | xargs --no-run-if-empty docker rm -f ||:
  sudo rm -fr "$TEMP_PATH" "$CACHES_PATH"
  SonarCloud:
- # TODO: Remove if: whenever SonarCloud supports c++23
- if: ${{ false }}
  runs-on: [self-hosted, builder]
  env:
  SONAR_SCANNER_VERSION: 4.8.0.2856
@@ -159,7 +157,7 @@ jobs:
  - name: Set Up Build Tools
  run: |
  sudo apt-get update
- sudo apt-get install -yq git cmake ccache ninja-build python3 yasm
+ sudo apt-get install -yq git cmake ccache ninja-build python3 yasm nasm
  sudo bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)"
  - name: Run build-wrapper
  run: |
@@ -178,4 +176,5 @@ jobs:
  --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" \
  --define sonar.projectKey="ClickHouse_ClickHouse" \
  --define sonar.organization="clickhouse-java" \
- --define sonar.exclusions="**/*.java,**/*.ts,**/*.js,**/*.css,**/*.sql" \
+ --define sonar.cfamily.cpp23.enabled=true \
+ --define sonar.exclusions="**/*.java,**/*.ts,**/*.js,**/*.css,**/*.sql"

README.md

@@ -16,18 +16,19 @@ curl https://clickhouse.com/ | sh
 * [YouTube channel](https://www.youtube.com/c/ClickHouseDB) has a lot of content about ClickHouse in video format.
 * [Slack](https://clickhouse.com/slack) and [Telegram](https://telegram.me/clickhouse_en) allow chatting with ClickHouse users in real-time.
 * [Blog](https://clickhouse.com/blog/) contains various ClickHouse-related articles, as well as announcements and reports about events.
-* [Code Browser (Woboq)](https://clickhouse.com/codebrowser/ClickHouse/index.html) with syntax highlight and navigation.
-* [Code Browser (github.dev)](https://github.dev/ClickHouse/ClickHouse) with syntax highlight, powered by github.dev.
+* [Code Browser (Woboq)](https://clickhouse.com/codebrowser/ClickHouse/index.html) with syntax highlighting and navigation.
+* [Code Browser (github.dev)](https://github.dev/ClickHouse/ClickHouse) with syntax highlighting, powered by github.dev.
+* [Static Analysis (SonarCloud)](https://sonarcloud.io/project/issues?resolved=false&id=ClickHouse_ClickHouse) proposes C++ quality improvements.
 * [Contacts](https://clickhouse.com/company/contact) can help to get your questions answered if there are any.
 
 ## Upcoming Events
 
 * [**v23.6 Release Webinar**](https://clickhouse.com/company/events/v23-6-release-call?utm_source=github&utm_medium=social&utm_campaign=release-webinar-2023-06) - Jun 29 - 23.6 is rapidly approaching. Original creator, co-founder, and CTO of ClickHouse Alexey Milovidov will walk us through the highlights of the release.
-* [**ClickHouse Meetup in Paris**](https://www.meetup.com/clickhouse-france-user-group/events/294283460) - Jul 4
 * [**ClickHouse Meetup in Boston**](https://www.meetup.com/clickhouse-boston-user-group/events/293913596) - Jul 18
 * [**ClickHouse Meetup in NYC**](https://www.meetup.com/clickhouse-new-york-user-group/events/293913441) - Jul 19
 * [**ClickHouse Meetup in Toronto**](https://www.meetup.com/clickhouse-toronto-user-group/events/294183127) - Jul 20
 * [**ClickHouse Meetup in Singapore**](https://www.meetup.com/clickhouse-singapore-meetup-group/events/294428050/) - Jul 27
+* [**ClickHouse Meetup in Paris**](https://www.meetup.com/clickhouse-france-user-group/events/294283460) - Sep 12
 
 Also, keep an eye out for upcoming meetups around the world. Somewhere else you want us to be? Please feel free to reach out to tyler <at> clickhouse <dot> com.
 

base/poco/Foundation/CMakeLists.txt

@@ -87,7 +87,6 @@ set (SRCS
  src/LoggingRegistry.cpp
  src/LogStream.cpp
  src/MD5Engine.cpp
- src/MemoryPool.cpp
  src/MemoryStream.cpp
  src/Message.cpp
  src/Mutex.cpp

base/poco/Net/include/Poco/Net/HTTPBasicStreamBuf.h

@@ -19,17 +19,16 @@
 
 
 #include "Poco/BufferedStreamBuf.h"
-#include "Poco/Net/HTTPBufferAllocator.h"
 #include "Poco/Net/Net.h"
 
 
 namespace Poco
 {
 namespace Net
 {
+ constexpr size_t HTTP_DEFAULT_BUFFER_SIZE = 8 * 1024;
 
-
- typedef Poco::BasicBufferedStreamBuf<char, std::char_traits<char>, HTTPBufferAllocator> HTTPBasicStreamBuf;
+ typedef Poco::BasicBufferedStreamBuf<char, std::char_traits<char>> HTTPBasicStreamBuf;
 
 
 }

base/poco/Net/include/Poco/Net/HTTPChunkedStream.h

@@ -21,7 +21,6 @@
 #include <cstddef>
 #include <istream>
 #include <ostream>
-#include "Poco/MemoryPool.h"
 #include "Poco/Net/HTTPBasicStreamBuf.h"
 #include "Poco/Net/Net.h"
 
@@ -80,12 +79,6 @@ namespace Net
  public:
  HTTPChunkedInputStream(HTTPSession & session);
  ~HTTPChunkedInputStream();
-
- void * operator new(std::size_t size);
- void operator delete(void * ptr);
-
- private:
- static Poco::MemoryPool _pool;
  };
 
 
@@ -95,12 +88,6 @@ namespace Net
  public:
  HTTPChunkedOutputStream(HTTPSession & session);
  ~HTTPChunkedOutputStream();
-
- void * operator new(std::size_t size);
- void operator delete(void * ptr);
-
- private:
- static Poco::MemoryPool _pool;
  };