Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set CMAKELIB_SRC_DIR as cache variable #8

Merged
merged 6 commits into from
Oct 23, 2021

Conversation

ClausKlein
Copy link
Contributor

@ClausKlein ClausKlein commented Sep 26, 2021

I renamed Index.cmake to CMakeLists.txt

Now it may be fetched and used with CPM.cmake module.

This offer the reuse of the cloned CMakeLib repo from ~/.cache/CPM ...

see usage example: https://github.com/ClausKlein/cpp_starter_project/blob/feature/use-cpm-cmake-module/CMakeLists.txt

TOO I fixed some minor problems found while testing the CMakeLib

@ClausKlein ClausKlein marked this pull request as draft September 26, 2021 19:03
Copy link
Owner

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase

@ClausKlein ClausKlein marked this pull request as ready for review September 27, 2021 06:30
src/Index.cmake Show resolved Hide resolved
Copy link
Owner

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had many issues with using CMakeLists.txt for a CMake library. It broke Conan dependencies the last time I tried it.

@ClausKlein
Copy link
Contributor Author

I had many issues with using CMakeLists.txt for a CMake library. It broke Conan dependencies the last time I tried it.

I will have a look at this

@ClausKlein ClausKlein changed the title Feature/use cpm cmake module Feature/make cmakelib usable Oct 4, 2021
@ClausKlein ClausKlein requested a review from aminya October 4, 2021 14:27
@aminya aminya force-pushed the feature/use-cpm-cmake-module branch from afe8759 to 8e04e29 Compare October 23, 2021 20:10
@aminya aminya force-pushed the feature/use-cpm-cmake-module branch from 8e04e29 to 7d0a7ac Compare October 23, 2021 20:17
@aminya aminya changed the title Feature/make cmakelib usable set CMAKELIB_SRC_DIR as cache variable Oct 23, 2021
@aminya aminya merged commit bd305ed into aminya:main Oct 23, 2021
@aminya
Copy link
Owner

aminya commented Oct 23, 2021

I reverted the cmake-format option as it was getting hard to follow. This should be a separate PR, and we should also update it in https://github.com/cpp-best-practices/cpp_starter_project.

@ClausKlein ClausKlein deleted the feature/use-cpm-cmake-module branch October 24, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants