feat(dependencies): update plugins and remove eslint@7 support #121
Conversation
BREAKING CHANGE: Require minimum of eslint 8 and node 16 required to fix bug in node 18
BREAKING CHANGE: eslint-config-prettier All configs merged into prettier BREAKING CHANGE: esling-plugin-prettier Drop support for eslint 5/6, prettier 1, node 6/8
|
@dogpatch626 I think an admin will have to update the required checks to merge this. |
package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "eslint": "^7.32.0 || ^8.8.0", | ||
| "eslint": "^8.42.0", | ||
| "eslint-plugin-jest": "^24.1.3 || ^25.7.0 || ^26.0.0 || ^27.0.0", |
There was a problem hiding this comment.
This isn't working with eslint-plugin-jest@24
$ npm i --save-dev eslint-plugin-jest@25
added 6 packages, removed 1 package, changed 6 packages, and audited 2299 packages in 16s
$ npm run test:lint
> [email protected] test:lint
> eslint --ignore-path .gitignore --ext js,jsx,snap .
$ npm i --save-dev eslint-plugin-jest@24
added 1 package, removed 6 packages, changed 6 packages, and audited 2294 packages in 15s
$ npm run test:lint
> [email protected] test:lint
> eslint --ignore-path .gitignore --ext js,jsx,snap .
Oops! Something went wrong! :(
ESLint: 8.42.0
TypeError: Failed to load plugin 'jest' declared in '__tests__/.eslintrc.json » eslint-config-amex/prettier/test': Class extends value undefined is not a constructor or null
Referenced from: /redacted/node_modules/eslint-config-amex/prettier/test.js
| "eslint-plugin-jest": "^24.1.3 || ^25.7.0 || ^26.0.0 || ^27.0.0", | |
| "eslint-plugin-jest": "^25.7.0 || ^26.0.0 || ^27.0.0", |
There was a problem hiding this comment.
It's not clear to me why this is breaking based on the breaking changes in v25:
https://github.com/jest-community/eslint-plugin-jest/releases/tag/v25.0.0
There was a problem hiding this comment.
Hey, appreciate you looking into this aswell. I was looking when I stumbled across this thread jest-community/eslint-plugin-jest#940 and installed 25.1.0 and npm run test:lint seems to run fine so far. going to test a little more
There was a problem hiding this comment.
Oh good call, yeah, it's not a breaking change for them to support a new major of a dependency.
https://github.com/jest-community/eslint-plugin-jest/releases/tag/v25.1.0
There was a problem hiding this comment.
Yea so just going to drop 24 from peer deps as this is dropping 7 anyways and 25 is the official support of eslint 8
smackfu
changed the title
smackfu
changed the title
# [16.0.0](v15.3.2...v16.0.0) (2023-06-15) ### Features * **dependencies:** update plugins and remove eslint@7 support ([#121](#121)) ([85cae7e](85cae7e)) ### BREAKING CHANGES * **dependencies:** Require minimum of eslint 8 and node 16 required to fix bug in node 18 * **dependencies:** eslint-config-prettier All configs merged into prettier * **dependencies:** esling-plugin-prettier Drop support for eslint 5/6, prettier 1, node 6/8
|
🎉 This PR is included in version 16.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
BREAKING CHANGES:
update to eslint-plugin-unicorn 47.0.0
update eslint-config-prettier v8
esling-plugin-prettier
Please make sure that the PR fulfills these requirements
Motivation and Context
How Has This Been Tested?
Types of changes