Do Not Try To Retry For IMDS V1 #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethAmazon
commented
Jul 28, 2023
| @@ -64,41 +63,23 @@ func GetHostInfo(logger *zap.Logger) (hostInfo *HostInfo) { | |||
| return | |||
| } | |||
|
|
|||
| ctx, cancel := context.WithTimeout(context.Background(), 2*override.TimePerCall) | |||
| defer cancel() | |||
| meta := ec2metadata.New(sess) | |||
There was a problem hiding this comment.
Reverted this back to the original state before my changes. @adam-mateen request to not change datadog.
There was a problem hiding this comment.
Could not revert datadog go.mod/sum bc it takes in the override from the connector
sethAmazon
force-pushed
the
do-not-retry-for-imdsv1-allow
branch
from
eee7862
to
376fea6
Compare
|
Could not revert datadog go.mod/sum bc it takes in the override from the connector |
sethAmazon
force-pushed
the
do-not-retry-for-imdsv1-allow
branch
from
376fea6
to
cc874ae
Compare
sky333999
approved these changes
Jul 28, 2023
adam-mateen
approved these changes
Jul 31, 2023
sethAmazon
merged commit e032a05
into
amazon-contributing:aws-cwa-dev
72 of 73 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Was not calling imdsv1 when retryer was enabled.
Link to tracking Issue:
N/A
Testing:
Tried using the private agent.
Documentation:
N/A