Reduce Retry Time And Add imds Fallback Client #62
Conversation
sethAmazon
force-pushed
the
reduce-retry-time
branch
from
0d95080
to
3cf5b47
Compare
sethAmazon
force-pushed
the
reduce-retry-time
branch
from
3cf5b47
to
4769595
Compare
sethAmazon
changed the title
sethAmazon
force-pushed
the
reduce-retry-time
branch
from
4769595
to
7af39ea
Compare
Add A Zap Logger To Imds Retryer And Reduce Retry Time Add Fallback Imds Client
sethAmazon
force-pushed
the
reduce-retry-time
branch
from
7af39ea
to
c958fb9
Compare
|
https://github.com/amazon-contributing/opentelemetry-collector-contrib/actions/runs/5692383918/job/15429388639?pr=62 |
| hostInfo.EC2Hostname = ec2HostnameInner | ||
| } else { | ||
| logger.Warn("Failed to get EC2 hostname", zap.Error(err)) | ||
| } |
There was a problem hiding this comment.
Do we really need to change the datadog exporter?
Do we somehow rely on code from this exporter in ours?
There was a problem hiding this comment.
No we do not. I just did a search for where imds was called and added the code there. I can remove this if need be, but I think it is fine to keep it.
| @@ -33,28 +34,28 @@ import ( | |||
| var IMDSRetryer request.Retryer = newIMDSRetryer() | |||
|
|
|||
| const ( | |||
| TimePerCall = 2 * time.Minute | |||
| TimePerCall = 30 * time.Second | |||
There was a problem hiding this comment.
What is the context for reducing this TimePerCall?
Business decision?
There was a problem hiding this comment.
We had a flaky test for 2 minutes in the private. I changed it to 30 seconds there so I changed it to 30 seconds here to match.
sethAmazon
merged commit d1a9d11
into
amazon-contributing:aws-cwa-dev
Description:
Reduce imds retry time to match downstream.
Link to tracking Issue:
N/A
Testing:
Tested downstream retry. This code is copied.
Documentation:
N/A