Fix imds retry #58
Merged
Fix imds retry #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 082d76a.
sethAmazon
commented
Jul 19, 2023
7dfcb28
to
8ed5eea
Compare
SaxyPandaBear
approved these changes
Jul 24, 2023
sky333999
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ec2 and ecs treats retries for getting host name differently
ec2 will try the method 5 times = about 2 minutes
ecs will try the underlying endpoints. Get token 5 times then call ec2 metadata then token 5 times then ec2 metadata ... = about 12 minutes
This was causing us to increase the max delay from 4 minutes to 24 minutes
Link to tracking Issue:
N/A
Testing:
Tested retry with context in private repo retry code. This is copied code.
Documentation:
N/A