Continuous vertical scrolling #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added continuousVertical option for continuous vertical scrolling Added CSS3 and Continuous demo pages Updated other demo pages to include links to CSS3 and Continuous demo pages
|
Fist of all thanks for the contribution! Looks great! |
|
I believe it's a great job! Once applied the changes, if you consider them an improvement, I will merge it. |
|
Yes, those simplify things. I have committed those - did they get updated with the pull request? |
|
Yeah. Everything is all right :) Thanks! |
alvarotrigo
added a commit
that referenced
this pull request
Feb 9, 2014
-Added new feature: continuous vertical scrolling by using the option `continuousVertical`
alvarotrigo
added a commit
that referenced
this pull request
Feb 11, 2014
alvarotrigo
added a commit
that referenced
this pull request
Apr 1, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to have the scrolling appear to be continuous - when you are at the last section and scroll down, the animation will continue downward but you will end up on the first section. It is similar when you are on the first section - scrolling up will cause the animation to continue upward but you will end up on the last section. Navigation is updated and hashes are maintained. This feature is very similar to the loopTop and loopBottom features but is targeted to make the end of a scroll (when there are many sections) not as jarring.
Clicking on a navigation dot, or navigating to an anchor directly, will use the normal animation: scroll up if the section is a prior one, scroll down if the animation is a later one.
And, just to be clear, this does not add horizontal scrolling (i.e. this is not a solution for issue 124).