[Tweak] Update "search filters" displayed on the blog's front page #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
george-gca
requested changes
Jun 5, 2024
There was a problem hiding this comment.
I think it makes more sense to keep blockquotes as tag, and just change the display_categories for external-services, since it is the only other category we have other than sample-posts.
- Display 'blockquotes' tag - Display 'external-services' category
george-gca
approved these changes
Jun 7, 2024
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
…lshedivat#2480) # [Tweak] Update "search filters" on blog's front page ## Current Behavior ``` 1. Go to `blog/` 2. Select "🏷️ Blockquotes" "search filter" => `blog/category/blockquotes/` returns 404 ``` <img width="400" alt="current-01-blog-filters" src="https://github.com/alshedivat/al-folio/assets/5504473/dae7f061-864d-49f3-9af1-1ef30c8056cd"> <img width="400" alt="current-02-category-blockquotes" src="https://github.com/alshedivat/al-folio/assets/5504473/c09422a9-a2c7-4f81-8534-1f310c4f9876"> <hr> ## Resolution in PR 1. Append 'blockquotes' to [`display_tags`](https://github.com/alshedivat/al-folio/pull/2480/files#diff-ecec67b0e1d7e17a83587c6d27b6baaaa133f42482b07bd3685c77f34b62d883R295) 2. Replace 'blockquotes' with 'external-services' in `display_categories` => Display 'blockquotes' tag and 'external-services' category on blog's front page <img width="400" alt="v2-01" src="https://github.com/alshedivat/al-folio/assets/5504473/c2f62a12-578d-44e0-ae8c-d6998fe8e2cb"> <br> <img width="300" alt="v2-02" src="https://github.com/alshedivat/al-folio/assets/5504473/8df86ea0-46d6-4389-904d-24965d74ace9"> <img width="300" alt="v2-03" src="https://github.com/alshedivat/al-folio/assets/5504473/6407812a-2052-4e0c-88bf-0d70d1c03ed8">
HaukeCornell
pushed a commit
to haukesand/haukesand.github.io
that referenced
this pull request
Jul 8, 2024
…lshedivat#2480) # [Tweak] Update "search filters" on blog's front page ## Current Behavior ``` 1. Go to `blog/` 2. Select "🏷️ Blockquotes" "search filter" => `blog/category/blockquotes/` returns 404 ``` <img width="400" alt="current-01-blog-filters" src="https://github.com/alshedivat/al-folio/assets/5504473/dae7f061-864d-49f3-9af1-1ef30c8056cd"> <img width="400" alt="current-02-category-blockquotes" src="https://github.com/alshedivat/al-folio/assets/5504473/c09422a9-a2c7-4f81-8534-1f310c4f9876"> <hr> ## Resolution in PR 1. Append 'blockquotes' to [`display_tags`](https://github.com/alshedivat/al-folio/pull/2480/files#diff-ecec67b0e1d7e17a83587c6d27b6baaaa133f42482b07bd3685c77f34b62d883R295) 2. Replace 'blockquotes' with 'external-services' in `display_categories` => Display 'blockquotes' tag and 'external-services' category on blog's front page <img width="400" alt="v2-01" src="https://github.com/alshedivat/al-folio/assets/5504473/c2f62a12-578d-44e0-ae8c-d6998fe8e2cb"> <br> <img width="300" alt="v2-02" src="https://github.com/alshedivat/al-folio/assets/5504473/8df86ea0-46d6-4389-904d-24965d74ace9"> <img width="300" alt="v2-03" src="https://github.com/alshedivat/al-folio/assets/5504473/6407812a-2052-4e0c-88bf-0d70d1c03ed8">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Tweak] Update "search filters" on blog's front page
Current Behavior
Resolution in PR
display_tagsdisplay_categories=> Display 'blockquotes' tag and 'external-services' category on blog's front page