Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom domain becomes blank after each deploy #130

Closed
eamanj opened this issue Oct 12, 2020 · 4 comments
Closed

custom domain becomes blank after each deploy #130

eamanj opened this issue Oct 12, 2020 · 4 comments
Labels

Comments

@eamanj
Copy link

eamanj commented Oct 12, 2020

I am using the theme to host my page on a custom domain. So the custom domain redirects to the github page. However, every time I deploy, my custom domain setting under github pages becomes empty and I have to reset it back to my domain (see image).

I thought I have to set some fields in the _config file, but nothing seemed to retain the custom domain name.
Thank you for the great work!

Screen Shot 2020-10-12 at 12 51 52 PM

@eamanj eamanj added the bug label Oct 12, 2020
@cdancette
Copy link

I had the same issue. You have to add the CNAME file to your master branch (check in your gh-pages branch to see its content).

By default when you add a custom domain, github adds the CNAME file to your gh-pages branch, which gets overwritten by the build from your master branch).

@kbrown
Copy link

kbrown commented Dec 26, 2020

e.g,. cat CNAME
foo.com

@rsonger
Copy link

rsonger commented Apr 10, 2022

Hi, thanks for the awesome work.

I realize this is a closed issue, but I noticed that the deploy action located in bin/deploy appears to be actively deleting CNAME files after the Jekyll build. Could this be adversely effecting custom domain settings on GitHub.com?

I can confirm that committing a CNAME file to master on the remote repository will keep the custom domain, but I wonder if it's necessary for the deploy action to be actively deleting the CNAME files.

@Fullchee
Copy link

@rsonger I'm getting the same thing

In my ci.yml I had mkdocs gh-deploy --force which removed the CNAME that GitHub added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants