Fix overlapping transitions with parent x-shows #853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, given the following code:
If you press the "toggle" button, then press it AGAIN while the "out" transition is still playing, instead of transitioning back in mid-way, the contents would immediately disappear.
This only happens when an x-transition is wrapped by an x-show without a transition.
This PR fixes this case, but rejecting the entire show directive stack at the component level once any transition within it has been cancelled.