Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Jasmine to dev dependencies #4163

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Jul 18, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Move Jasmine to dev dependencies as it is only required for running tests and does not need to be present in production.

Why

This is preparing for #4142

Trello card

@govuk-ci govuk-ci temporarily deployed to govuk-frontend-app-pr-4163 July 18, 2024 11:20 Inactive
@unoduetre unoduetre changed the title Move Jasmine to dev dependencies Implement JavaScript test coverage checking Jul 18, 2024
@unoduetre unoduetre changed the title Implement JavaScript test coverage checking Implement JavaScript test coverage checking [1/] Jul 18, 2024
@unoduetre unoduetre changed the title Implement JavaScript test coverage checking [1/] Implement JavaScript test coverage checking [1/4] Jul 18, 2024
@unoduetre unoduetre changed the title Implement JavaScript test coverage checking [1/4] Move Jasmine to dev dependencies Jul 18, 2024
@unoduetre unoduetre marked this pull request as ready for review July 18, 2024 13:14
@unoduetre unoduetre merged commit de6662d into main Jul 19, 2024
13 checks passed
@unoduetre unoduetre deleted the 2664-investigate-adding-javascript-test-coverage-and-implement-it-if-possible-l-1 branch July 19, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants