Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a Docker build stage for JS #209

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Use a Docker build stage for JS #209

merged 1 commit into from
Nov 29, 2023

Conversation

andyhd
Copy link
Contributor

@andyhd andyhd commented Nov 28, 2023

  • Avoids adding ~100MB of JS libraries to the image which are not needed at run-time
  • Simpler - using official Node base image avoids installing nvm, node, etc - less to maintain

@andyhd andyhd added the norelease Don't bump version number or create a release label Nov 28, 2023
@andyhd andyhd marked this pull request as draft November 28, 2023 15:09
@andyhd andyhd force-pushed the andyhd/chore/refactor-dockerfile branch from 4d4c401 to 6d0bc09 Compare November 28, 2023 16:13
@andyhd andyhd marked this pull request as ready for review November 28, 2023 16:13
@andyhd
Use a Docker build stage for JS
879f7ea 
* Avoids adding ~100MB of JS libraries to the image which are not needed at
  run-time
* Simpler - using official Node base image avoids installing nvm, node, etc -
  less to maintain
@andyhd andyhd force-pushed the andyhd/chore/refactor-dockerfile branch from 6d0bc09 to 879f7ea Compare November 28, 2023 16:17
nacnudus
nacnudus approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@nacnudus nacnudus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

guilhem-fry
guilhem-fry approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@guilhem-fry guilhem-fry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyhd andyhd merged commit 2122e24 into main Nov 29, 2023
3 checks passed
@andyhd andyhd deleted the andyhd/chore/refactor-dockerfile branch November 29, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nacnudus nacnudus nacnudus approved these changes

@guilhem-fry guilhem-fry guilhem-fry approved these changes

Assignees
No one assigned
Labels
norelease Don't bump version number or create a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyhd @nacnudus @guilhem-fry