Skip to content

Commit

Permalink
Change filtered response error icon to info icon (microsoft#178174)
Browse files Browse the repository at this point in the history
  • Loading branch information
roblourens authored Mar 23, 2023
1 parent 8d19f1c commit deedbd3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ export class InteractiveListItemRenderer extends Disposable implements ITreeRend
templateData.elementDisposables.add(result);

if (isResponseVM(element) && element.errorDetails?.message) {
const errorDetails = dom.append(templateData.value, $('.interactive-response-error-details', undefined, renderIcon(Codicon.error)));
const icon = element.errorDetails.responseIsFiltered ? Codicon.info : Codicon.error;
const errorDetails = dom.append(templateData.value, $('.interactive-response-error-details', undefined, renderIcon(icon)));
errorDetails.appendChild($('span', undefined, element.errorDetails.message));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@

.interactive-session .interactive-response .interactive-response-error-details .codicon {
margin-top: 1px;
}

.interactive-session .interactive-response .interactive-response-error-details .codicon-error {
color: var(--vscode-errorForeground) !important; /* Have to override default styles which apply to all lists */
}

Expand Down

0 comments on commit deedbd3

Please sign in to comment.