cli: use better approach to Windows services (microsoft#172679)

Fixes microsoft#167741

This eschews the offical Windows service system in favor of registering
into `HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run`.
Unlike services, this can be done without administrative permissions,
does not require the current username/password, and is not blocked by
miscellaneous and mysterious system policies.

Since the process is basically unmanaged by the OS, this requires a
little legwork to start and stop the process when registering and
unregistering.

cli/Cargo.toml

@@ -49,13 +49,13 @@ log = "0.4"
 const_format = "0.2"
 sha2 = "0.10"
 base64 = "0.13"
+shell-escape = "0.1.5"
 
 [build-dependencies]
 serde = { version = "1.0" }
 serde_json = { version = "1.0" }
 
 [target.'cfg(windows)'.dependencies]
-windows-service = "0.5"
 winreg = "0.10"
 winapi = "0.3.9"
 

cli/src/constants.rs

@@ -61,6 +61,9 @@ pub const QUALITYLESS_SERVER_NAME: &str = concatcp!(QUALITYLESS_PRODUCT_NAME, "
 /// Web URL the editor is hosted at. For VS Code, this is vscode.dev.
 pub const EDITOR_WEB_URL: Option<&'static str> = option_env!("VSCODE_CLI_EDITOR_WEB_URL");
 
+/// Name shown in places where we need to tell a user what a process is, e.g. in sleep inhibition.
+pub const TUNNEL_ACTIVITY_NAME: &str = concatcp!(PRODUCT_NAME_LONG, " Tunnel");
+
 const NONINTERACTIVE_VAR: &str = "VSCODE_CLI_NONINTERACTIVE";
 
 pub fn get_default_user_agent() -> String {

cli/src/tunnels/nosleep_macos.rs

@@ -5,12 +5,11 @@
 
 use std::io;
 
-use const_format::concatcp;
 use core_foundation::base::TCFType;
 use core_foundation::string::{CFString, CFStringRef};
 use libc::c_int;
 
-use crate::constants::APPLICATION_NAME;
+use crate::constants::TUNNEL_ACTIVITY_NAME;
 
 extern "C" {
  pub fn IOPMAssertionCreateWithName(
@@ -64,8 +63,7 @@ pub struct SleepInhibitor {
 impl SleepInhibitor {
  pub async fn new() -> io::Result<Self> {
  let mut assertions = Vec::with_capacity(NUM_ASSERTIONS);
- let assertion_name =
- CFString::from_static_string(concatcp!(APPLICATION_NAME, " running tunnel"));
+ let assertion_name = CFString::from_static_string(concatcp!(TUNNEL_ACTIVITY_NAME));
  for typ in ASSERTIONS {
  assertions.push(Assertion::make(
  &CFString::from_static_string(typ),

cli/src/tunnels/nosleep_windows.rs

@@ -5,7 +5,6 @@
 
 use std::io;
 
-use const_format::concatcp;
 use winapi::{
  ctypes::c_void,
  um::{
@@ -19,15 +18,13 @@ use winapi::{
  },
 };
 
-use crate::constants::APPLICATION_NAME;
+use crate::constants::TUNNEL_ACTIVITY_NAME;
 
 struct Request(*mut c_void);
 
 impl Request {
  pub fn new() -> io::Result<Self> {
- let mut reason: Vec<u16> = concatcp!(APPLICATION_NAME, " running tunnel")
- .encode_utf16()
- .collect();
+ let mut reason: Vec<u16> = TUNNEL_ACTIVITY_NAME.encode_utf16().collect();
  let mut context = REASON_CONTEXT {
  Version: POWER_REQUEST_CONTEXT_VERSION,
  Flags: POWER_REQUEST_CONTEXT_SIMPLE_STRING,