Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interslavic translation #2373

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

noomorph
Copy link
Contributor

@noomorph noomorph commented Feb 27, 2024

Context

Hello! At the Interslavic OSS organization, we aim to cover morphological and orthographical functionality (word inflection, verb conjugation, transliteration, etc.) with unit tests, and while English is a good choice for keeping technical documentation, it is preferable to make reports accessible for every contributor to Interslavic language:

isv-utils-allure-121 surge sh_

New translation

Dashboard Test page
dashboard test_page

Developer notes

  1. Since Interslavic is not supported by i18next directly, I had to copy&paste suitable pluralization rules (1,2,5):
i18next.on("initialized", () => {
  const pluralResolver = i18next.services.pluralResolver;
  pluralResolver.addRule("isv", pluralResolver.getRule("be"));
});
  1. The last contributor who submitted Turkish translation accidently converted some of files to CRLF. My pull request brings LF endings back. Please use the "Hide whitespace" option on GitHub when reviewing.

  2. The language code used ("isv") is not official yet, although our pending ISO committee submissions for code pretend exactly for this one. I could have used "art-x-interslv" (current idiomatic BCP 47 identifier according to CLCR), but that would require extra changes to your Handlebars template rendering – e.g., to introduce some language.abbr property along with language.id to avoid breaking the language selector visually.

Checklist

  • Sign Allure CLA
  • Provide unit tests
    Not sure if this is applicable here – there are no IF-ELSE branches in my i18next plural augmentation code, and the API I'm using is stable enough – it is still available both in i18next@8 and in i18next@23, so I don't see major reasons to worry. 🤷‍♂️

P.S. @ru-danko, thanks for checking on the translation keys.

Copy link
Member

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dobra rabota!

@epszaw epszaw added the type:improvement Change that improves some user experience but can't be considered as a new feature label Feb 27, 2024
@baev baev merged commit 76b06e7 into allure-framework:main Feb 27, 2024
9 of 10 checks passed
@noomorph noomorph deleted the feat/i18n-interslavic branch February 27, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:plugins theme:ui type:improvement Change that improves some user experience but can't be considered as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants