Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP Compatibility Checks for Version 8.1 and 8.2 #5

Closed
kevinfodness opened this issue Mar 29, 2022 · 2 comments · Fixed by #65
Closed

Add PHP Compatibility Checks for Version 8.1 and 8.2 #5

kevinfodness opened this issue Mar 29, 2022 · 2 comments · Fixed by #65
Assignees
@moraleida
Labels
ci/cd PR checks, deploys, automation enhancement New feature or request

Comments

@kevinfodness
Copy link
Member

kevinfodness commented Mar 29, 2022 •
edited
Loading

User Story

As a developer, I want to ensure that Elasticsearch Extensions is compatible with all currently supported versions of PHP.

Acceptance Criteria

  • Ensure that Elasticsearch Extensions declares support for PHP 8.1 and 8.2 in composer.json
  • Ensure that it states a required minimum of PHP 8.1 in the plugin's metadata
  • Ensure that PHPUnit tests are run against PHP 8.1 and 8.2
  • Ensure that phpcs compatibility checks are set to check against PHP 8.1, 8.2
@kevinfodness kevinfodness mentioned this issue Mar 29, 2022
Merged
@mboynes mboynes changed the title Add PHP Compatibility Checks for Version 8.0 and 8.1 Add PHP Compatibility Checks for Version 8.0 - 8.2 Oct 11, 2023
@kevinfodness kevinfodness changed the title Add PHP Compatibility Checks for Version 8.0 - 8.2 Add PHP Compatibility Checks for Version 8.1 and 8.2 Oct 18, 2023
@kevinfodness kevinfodness added enhancement New feature or request ci/cd PR checks, deploys, automation labels Oct 18, 2023
@moraleida moraleida self-assigned this Nov 21, 2023
@moraleida moraleida mentioned this issue Nov 24, 2023
Merged
@moraleida
Copy link
Contributor

@kevinfodness this is ready for review. Please notice that to get all AC we needed to bump the minimum PHP version to 8.1 and the minimum WP version to 6.2. Let me know if you want to discuss the approaches.

@moraleida
Copy link
Contributor

I addressed the changes in the PR and this is ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moraleida moraleida

Labels
ci/cd PR checks, deploys, automation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PHPCS checks for PHP 8.1 and 8.2 alleyinteractive/elasticsearch-extensions
2 participants
@moraleida @kevinfodness