Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs with layer matching and static path templates #45

Merged
merged 15 commits into from
May 2, 2016
Merged

Fix bugs with layer matching and static path templates #45

merged 15 commits into from
May 2, 2016

Conversation

mboynes
Copy link
Contributor

@mboynes mboynes commented Apr 15, 2016 •
edited
Loading

Needs to follow #43, #44. After they're merged, this PR will trim down considerably.

  • Differentiates between page type matches for singular and archive post type views
  • Fixes bug with static paths (if a path template didn't have a formatting tag, it returned the default)
  • Fixes bug with taxonomy page type matches
  • Adds full test coverage for active layer detection

This started off as a simple fix to #42, but ended up addressing several bugs uncovered via unit testing.

@mboynes mboynes changed the title Differentiate between post archives and singular Fix bugs with layer matching and static path templates Apr 15, 2016
@bcampeau
Copy link
Member

bcampeau commented May 2, 2016

🐴

@mboynes mboynes merged commit 05f55ed into master May 2, 2016
@mboynes mboynes deleted the post-archive-bug branch December 7, 2017 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mboynes @bcampeau