add progress bar to http_get #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was somthing wrong with my downstream repo so I close the old PR and raise this one again. |
dakinggg
previously approved these changes
Oct 19, 2023
dakinggg
reviewed
Oct 19, 2023
Signed-off-by: Weixiong Lin <[email protected]>
WeixiongLin
force-pushed
the
issue-490
branch
from
a42656a
to
bbafd00
Compare
|
I have fix the problem, thanks for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discussed with the maintainer in issue-490, and encouraged to raise this PR.
Gist:
To use scispacy, some of the resources are fetched from web url, e.g. URL of tfidf_vectors_sparse. And the size of the resources could be up to 500M, thereby taking several miutes to complete downloading. Somehow scispacy download quietly without signals for users, so thet can't tell whether the progress stucks or not.
So I add a progress bar to the function
http_getto let users know where they are.Scispacy helps me a lot in my research, thanks for your contribution to our community. And thanks for your review.