Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Updated the docs for PytorchSeq2VecWrapper to specify that mask is required #5386

Merged
merged 8 commits into from
Mar 11, 2022

Conversation

gabeorlanski
Copy link
Contributor

@gabeorlanski gabeorlanski commented Aug 29, 2021

Fixes #5385.

Changes proposed in this pull request:

  • Updated the docs for PytorchSeq2VecWrapper to specify that mask is required rather than sequence lengths for clarity.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.
  • codecov/patch reports high test coverage (at least 90%).
    You can find this under the "Actions" tab of the pull request once the other checks have finished.

@AkshitaB AkshitaB enabled auto-merge (squash) March 11, 2022 05:18
@AkshitaB AkshitaB merged commit 5f5f8c3 into allenai:main Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PytorchSeq2VecWrapper documentation
2 participants