fix(check-version): change to return cached latest version only if valid #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. None
What was done?
The function
cache_daily_versionwas modified to return the cached latest version only if it is valid (i.e., not None).How was it done?
A check was added to ensure that the cached latest version is returned only if it is not None. This prevents the function from returning an invalid cached version.
How was it tested?
The change was tested by simulating scenarios where the cache contains a valid version, an invalid version (None), and no version at all. The function was observed to return the correct version or proceed to fetch a new version as expected.