fix(base_branch): fix base branch usage in missing parts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82a444e
to
2017eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done?
The base branch usage was fixed in the parts where it was missing. The changes were made in the
gh.py,gitutil.py, andprdata.pyfiles. The base branch is now correctly used in the creation of pull requests, getting branch info, and getting diff changes.How was it done?
The changes were made in the
create_prfunction ingh.py, where the base branch is now correctly used when creating a pull request. Ingitutil.py, the base branch is now correctly used in theget_branch_infoand_get_diff_changesfunctions. Inprdata.py, the base branch is now correctly displayed in thePrDataclass.How was it tested?
The changes were tested by running the modified functions and checking if the base branch is correctly used and displayed. The diff changes show that the base branch is now correctly used in the mentioned functions and classes.