Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta limits to track and act on repeated rate limit breaches #418

Merged
merged 13 commits into from
Aug 31, 2023
Merged

Meta limits to track and act on repeated rate limit breaches #418

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
af2200f
Add initial implementation of breach limits
alisaifee Aug 23, 2023
82aebef
Improve tests for breach limits
alisaifee Aug 23, 2023
bb67d3c
Remove dangling print statement
alisaifee Aug 28, 2023
4f38c5a
Exercise breach limits from config in tests
alisaifee Aug 28, 2023
03e10ee
Fix typo in initializing breach limits from config
alisaifee Aug 28, 2023
6db533b
Document new configuration
alisaifee Aug 29, 2023
d808a8d
Add recipe for breach limits
alisaifee Aug 29, 2023
779f3db
Add breach limits to console interface
alisaifee Aug 29, 2023
3733121
Add breach limits to kithensink factory
alisaifee Aug 29, 2023
f20f8c2
Change breach_limit->meta_limit
alisaifee Aug 30, 2023
d854cea
Improve wording in recipe
alisaifee Aug 30, 2023
b710a3c
Ensure on breach callbacks from config are respected
alisaifee Aug 30, 2023
5456780
Reword breach->meta
alisaifee Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensure on breach callbacks from config are respected
  • Loading branch information
@alisaifee
alisaifee committed Aug 30, 2023
commit b710a3c99fb18dcb7b6128aebc519d8ec76467c9
8 changes: 7 additions & 1 deletion flask_limiter/extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,6 +459,12 @@ def init_app(self, app: flask.Flask) -> None:
shared=True,
)
]

self._on_breach = self._on_breach or config.get(ConfigVars.ON_BREACH, None)
self._on_meta_breach = self._on_meta_breach or config.get(
ConfigVars.ON_META_BREACH, None
)

self.__configure_fallbacks(app, self._strategy)

if self not in app.extensions.setdefault("limiter", set()):
Expand Down Expand Up @@ -1042,7 +1048,7 @@ def __evaluate_limits(self, endpoint: str, limits: List[Limit]) -> None:
except Exception as err: # noqa
if self._swallow_errors:
self.logger.exception(
"on_breach callback failed with error %s", err
"on_meta_breach callback failed with error %s", err
)
else:
raise err
Expand Down
Loading