Default Attribute Value On Instance #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DK070202
suggested changes
Sep 22, 2022
lib/src/growth_book_sdk.dart
Outdated
| @@ -8,15 +8,15 @@ abstract class SDKBuilder { | |||
| SDKBuilder({ | |||
| required this.apiKey, | |||
| required this.hostURL, | |||
| required this.attributes, | |||
| this.attributes, | |||
There was a problem hiding this comment.
attributes should not be null. Instead, you can initialize this with a default value.
SDKBuilder({
required this.apiKey,
required this.hostURL,
this.attributes = const {},
})There was a problem hiding this comment.
I see in the super constructor is nullable, why attributes from SDKBuilder should not be null? What's the impact when we send null or empty map?
There was a problem hiding this comment.
The core FeatureEvaluator evaluates the condition against the attributes and the condition. If attributes are null then we can not evaluate the condition. It's better to have empty in place of null attributes.
make sure it's formatted before you push code. You can ensure it by flutter format .. You can fire this from root.
LGTM.
chandrabezzo
changed the title
DK070202
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make attributes nullable when instance SDK