Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#12359]Refactoring the historical configuration cleanup strategy with SPI #12367

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Sunrisea
Copy link
Contributor

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix issue#12359

Brief changelog

Refactoring the historical configuration cleanup strategy with SPI (Service Provider Interface), and add unit test for
DefaultHistoryConfigCleaner ,HistoryConfigCleanerManager and HistoryConfigCleanerConfig

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种方案是否要求拓展者必须依赖nacos-config模块才可以开发拓展?

@Sunrisea
Copy link
Contributor Author

这种方案是否要求拓展者必须依赖nacos-config模块才可以开发拓展?

是的

@Override
public void run() {
clearConfigHistory();
LOGGER.warn("clearHistoryConfig start");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.when canExecute return false/true ,print log also ,like 'history config cleaner is not enable in current context' , 'history config cleaner is enable in current context, trying to run cleaner.'
2.when cleaner run finish ,print log like 'history cleaner finished successfully' and should catch exception when cleaner throw exception ,or it wont be scheduled next period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants