Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useWebSocket初始socketUrl为空报错，更新socketUrl导致无限重连 #2176

Closed
YinDongFang opened this issue Apr 26, 2023 · 1 comment · Fixed by #2177
Closed

useWebSocket初始socketUrl为空报错，更新socketUrl导致无限重连 #2176

YinDongFang opened this issue Apr 26, 2023 · 1 comment · Fixed by #2177

Comments

@YinDongFang
Copy link
Contributor

问题1：useWebSocket参数socketUrl初始值为空报错

image

复现地址：https://codesandbox.io/s/empty-initial-socketurl-z2uwvm?file=/App.tsx

预期：当初始socketUrl为空值时不执行connect

问题2：useWebSocket更新socketUrl导致无限重连

复现地址：https://codesandbox.io/s/update-socketurl-d1jjww?file=/App.tsx

复现步骤：等待连接成功后点击update

预期：更新socketUrl后重新建立连接并不会触发reconnect
YinDongFang added a commit to YinDongFang/hooks that referenced this issue Apr 26, 2023
@YinDongFang
fix: useWebSocket unlimited reconnect when update socketUrl alibaba#2176
3b11aa9
YinDongFang added a commit to YinDongFang/hooks that referenced this issue Apr 26, 2023
@YinDongFang
fix: useWebSocket don't call connect when socketUrl is empty (alibaba…
d30f893 
…#2176)
YinDongFang added a commit to YinDongFang/hooks that referenced this issue Apr 26, 2023
@YinDongFang
fix: useWebSocket unlimited reconnect when update socketUrl (alibaba#…
ef8ec43 
…2176)
@YinDongFang YinDongFang mentioned this issue Apr 26, 2023
Merged
18 tasks
@YinDongFang
Copy link
Contributor Author

相关issue：#1523

crazylxr pushed a commit that referenced this issue Jun 6, 2023
@YinDongFang
fix useWebSocket error (#2176) (#2177)
52bc820 
* fix: useWebSocket don't call connect when socketUrl is empty (#2176)

* fix: useWebSocket unlimited reconnect when update socketUrl (#2176)

* fix: disconnect not works

* docs: modify useWebSocket docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix useWebSocket error (#2176) YinDongFang/hooks
1 participant
@YinDongFang