Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for README #5

Merged
merged 7 commits into from
Jan 24, 2022
Merged

Minor fixes for README #5

merged 7 commits into from
Jan 24, 2022

Conversation

KengoTODA
Copy link
Contributor

Describe what this PR does / why we need it

I just found minor issues in README files, so want to suggest these fixes.

Does this pull request fix one issue?

NONE

Describe how you did it

  • Replace "," with ","
  • Replace "。" with "."
  • Correct wrong copyright holder info

Describe how to verify it

Probably we need to ask a human to review manually :)

Special notes for reviews

Sorry for such minor and small proposal!

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ KengoTODA
❌ zhongxig
You have signed the CLA already but the status is still pending? Let us recheck it.

reset to apache foundation
fix(readme): update Introduction
@zhongxig zhongxig merged commit c71607a into alibaba:main Jan 24, 2022
@KengoTODA KengoTODA deleted the patch-1 branch January 25, 2022 01:43
@@ -81,5 +81,5 @@ details see [here](docs/en/contributing/contributing.md)

## License

[Apache License, Version 2.0](http:https://www.apache.org/licenses/LICENSE-2.0.html) Copyright 1999-2022 Alibaba Group Holding Ltd.
[Apache License, Version 2.0](http:https://www.apache.org/licenses/LICENSE-2.0.html) Copyright (C) Apache Software Foundation.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongxig can I ask why we reverted this change?

I believe that we need to tell the copyright holder of this project. Refer to the following projects as live examples:

The copyright of license is usually described in the license distribution page. In this case at the footer in the license distribution page. So we do not need to write its copyright holder here, which may lead readers to misunderstanding.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KengoTODA
Thanks for the reminder, the description of the readme License has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants