feat(Tree): dataSource item add remarks close #4644 #4864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalsky
requested changes
Jun 21, 2024
| @@ -313,6 +313,7 @@ export interface TreeProps< | |||
| /** | |||
| * 数据源，该属性优先级高于 children | |||
| * @en Data source of the tree component | |||
| * @remarks item中多余的属性会传递给 tree node 内的 <li></li> 节点,并被渲染 | |||
There was a problem hiding this comment.
中英文之间要空格，如 item 和中之间。另外需要有英文的部分，用 - 隔开
There was a problem hiding this comment.
另外这个描述还可以再优化一下。并被渲染不用提，传给 li，自然是会要渲染的。
There was a problem hiding this comment.
types 改了之后要运行一下 npm run api tree，更新一下 readme
eternalsky
requested changes
Jun 21, 2024
| @@ -313,6 +313,7 @@ export interface TreeProps< | |||
| /** | |||
| * 数据源，该属性优先级高于 children | |||
| * @en Data source of the tree component | |||
| * @remarks item中多余的属性会传递给 tree node 内的 <li></li> 节点,并被渲染 | |||
There was a problem hiding this comment.
types 改了之后要运行一下 npm run api tree，更新一下 readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.